fix fd leaks and detect them as comprehensively as possible #5026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifubang
force-pushed
the
ci-detect-fdleak-try-best
branch
4 times, most recently
from
3cb900b to
f906fd3
Compare
This was referenced Nov 19, 2025
lifubang
force-pushed
the
ci-detect-fdleak-try-best
branch
2 times, most recently
from
c3ecaea to
9b8549e
Compare
lifubang
changed the title
cyphar
reviewed
Nov 20, 2025
cyphar
added
backport/1.2-todo
lifubang
force-pushed
the
ci-detect-fdleak-try-best
branch
from
9b8549e to
4c4376a
Compare
lifubang
force-pushed
the
ci-detect-fdleak-try-best
branch
from
4c4376a to
0127cc6
Compare
lifubang
added
backport/1.2-done
cyphar
approved these changes
Nov 20, 2025
cyphar
changed the title
Co-authored-by: Aleksa Sarai <[email protected]> Signed-off-by: lifubang <[email protected]>
Signed-off-by: lifubang <[email protected]>
Signed-off-by: lifubang <[email protected]>
Signed-off-by: lifubang <[email protected]>
Signed-off-by: lifubang <[email protected]>
lifubang
force-pushed
the
ci-detect-fdleak-try-best
branch
from
67f15f8 to
d870650
Compare
Member
Author
|
@opencontainers/runc-maintainers PTAL -- I’d like to propose cutting releases for v1.2.9, v1.3.4, and v1.4.0 this week. Please let me know if there are any concerns or blockers. |
Member
|
Yeah this is the only blocker left for those releases, it'd be nice to get it done this week... |
AkihiroSuda
reviewed
Nov 25, 2025
| github.com/containerd/console v1.0.5 | ||
| github.com/coreos/go-systemd/v22 v22.6.0 | ||
| github.com/cyphar/filepath-securejoin v0.6.0 | ||
| github.com/cyphar/filepath-securejoin v0.6.1 |
Member
There was a problem hiding this comment.
This could be bumped up by dependabot?
Member
Author
There was a problem hiding this comment.
Yes, I closed the Dependabot bump PR because we need these two PRs to fix #5021.
AkihiroSuda
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #5021
Fix: #5007
Close: #5022
Close: #5024
Close: #5015
Without deferring the closure of this file descriptor, starting a container with a very large number of devices can hit the
RLIMIT_NOFILElimit.