Fix various state bugs for pause and destroy #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were issues where a process could die before pausing completed leaving the container in an inconsistent state and unable to be destoryed. This makes sure that if the container is paused and the process is dead it will unfreeze the cgroup before removing them. Signed-off-by: Michael Crosby <[email protected]>
Signed-off-by: Michael Crosby <[email protected]>
Member
|
@crosbymichael Does this solve all of the related failing Jenkins tests and do you know what test triggered the bug? |
|
I might have missed it, but I think nullState isn't used any more with this PR - can we remove it? |
|
oh darn, I missed one in the factory during a load - could stoppedState be used there instead? |
Member
Author
|
ok once/if this is merged I'll play with it. |
Member
Author
Contributor
|
@crosbymichael Yeah, reviewing/testing. |
Merged
Contributor
|
LGTM |
Contributor
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Jan 25, 2016
Fix various state bugs for pause and destroy
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Carry opencontainers#499 For these values, cgroup kernal APIs accept -1 to set them as unlimited, as docker and runc all support update resources, we should not set drawbacks in spec. Signed-off-by: Qiang Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were issues where a process could die before pausing completed
leaving the container in an inconsistent state and unable to be
destoryed. This makes sure that if the container is paused and the
process is dead it will unfreeze the cgroup before removing them.
Closes #484
Closes #470
Signed-off-by: Michael Crosby [email protected]