Embed Resources for backward compatibility #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could this cause issues with |
libcontainer/configs/cgroup_unix.go
Outdated
Contributor
There was a problem hiding this comment.
I sort of don't understand why we need to embed it? Why just don't use value instead of pointer?
Contributor
There was a problem hiding this comment.
Oh, sorry, it's for backward compatibility.
Contributor
|
Hmm, the idea behind making Resources a pointer was that in the future we can clean up the API so if Resources are nil, we can just join instead of create. |
Contributor
|
@mrunalp I think we can embed pointer. |
Contributor
|
Cool. I would prefer that. Sent from my iPhone
|
Fixes: moby/moby#19329 Signed-off-by: Qiang Huang <[email protected]>
hqhq
force-pushed
the
hq_embed_resource
branch
from
2da0993 to
f048eaf
Compare
Contributor
Author
Member
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Jan 19, 2016
Embed Resources for backward compatibility
Contributor
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: moby/moby#19329
Signed-off-by: Qiang Huang [email protected]