Make state.json 25% smaller #4685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the state.json file 1303 bytes or almost 25% smaller (when using the default spec, YMMV) by omitting default values. Before: 5496 bytes After: 4193 bytes (With cgroups#9 applied, the new size is 3424, which is almost 40% savings, compared to the original). Signed-off-by: Kir Kolyshkin <[email protected]>
rata
approved these changes
Mar 20, 2025
Member
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
haha, awesome!
I thought I already reviewed this, but it seems I got interrupted by a meeting before posting. Thanks for the ping :)
AkihiroSuda
approved these changes
Mar 21, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the state.json file 1303 bytes or almost 25% smaller (when using the default spec, YMMV) by omitting default values.
Before: 5496 bytes
After: 4193 bytes
(With opencontainers/cgroups#9 applied on top, the new size is 3424, which is almost 40% savings, compared to the original).