Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA CI bumps #4561

Merged
merged 2 commits into from
Dec 19, 2024
Merged

GHA CI bumps #4561

merged 2 commits into from
Dec 19, 2024

Conversation

kolyshkin
Copy link
Contributor

  1. golangci-lint v1.60 --> v1.62
  2. ubuntu-latest -> ubuntu-24.04

@kolyshkin
ci: bump golangci-lint to v1.62
e845f4b 
Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
ci: use a specific ubuntu version
9468986 
GHA shows a warning telling that "ubuntu-latest" is going to be switched
to ubuntu-24.04 soon. Let's specify the version explicitly (and switch
to 24.04 for this job ahead of github).

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin mentioned this pull request Dec 18, 2024
Merged
@kolyshkin
Copy link
Contributor Author

Added a commit from #4560 to test if a linter warning (from #4560 (comment)) goes away.

@kolyshkin
Copy link
Contributor Author

Added a commit from #4560 to test if a linter warning (from #4560 (comment)) goes away.

Apparently it does (https://github.com/opencontainers/runc/actions/runs/12388144628/job/34578756275?pr=4561). Removing the commit from #4560.

@kolyshkin kolyshkin marked this pull request as ready for review December 18, 2024 07:53
cyphar
cyphar approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really quite strange that this happened at all and that a version bump fixes it. I wonder what the original bug was...

@lifubang lifubang added area/ci backport/1.2-todo A PR in main branch which needs to be backported to release-1.2 labels Dec 19, 2024
@lifubang lifubang merged commit 90f38e7 into opencontainers:main Dec 19, 2024
76 checks passed
@lifubang lifubang modified the milestone: 1.2.4 Dec 19, 2024
@lifubang lifubang removed the backport/1.2-todo A PR in main branch which needs to be backported to release-1.2 label Dec 19, 2024
@lifubang
Copy link
Member

lifubang commented Dec 19, 2024 •
edited
Loading

Remove the backport/1.2-todo label, once the CI is failed with the similar reason in release-1.2, we can add it back at that time.
Please see: #4560 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyphar cyphar cyphar approved these changes

@lifubang lifubang lifubang approved these changes

Assignees
No one assigned
Labels
area/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolyshkin @lifubang @cyphar