Add Go 1.23, drop 1.21 #4360
Add Go 1.23, drop 1.21 #4360
Conversation
kolyshkin
force-pushed
the
go123
branch
2 times, most recently
from
6fd183b
to
649ec2c
Compare
kolyshkin
force-pushed
the
go123
branch
2 times, most recently
from
58fe7d4
to
a178aad
Compare
kolyshkin
added
area/ci
backport/done/1.1
|
1.1 backport: #4372 |
|
We need this one to fix cirrus-ci failing as it can't download Go 1.21. PTAL @opencontainers/runc-maintainers |
| @@ -1,6 +1,6 @@ | |||
| module github.com/opencontainers/runc | |||
|
|
|||
| go 1.21 | |||
| go 1.22 | |||
There was a problem hiding this comment.
Should we keep this 1.22.4, since 1.22.0-3 has known issue with runc?
There was a problem hiding this comment.
We want to test with the latest 1.22, not just 1.22.4. That will just test 1.22.4, right?
Sure, we don't want to test with earlier than 1.22.4, but IIUC there is no way to express that and no CI is using failing due to that (all are using older already). IMHO we should keep 1.22 to test the latest releases too.
There was a problem hiding this comment.
Right, alas there's no way to say "we want 1.22 >= 1.22.4" (I tried hard to find it but failed).
- drop Go 1.21; - add Go 1.23; - for a few jobs that were using Go 1.21, switch to 1.22; Also, bump go to 1.22 in go.mod. Signed-off-by: Kir Kolyshkin <[email protected]>
The warnings fixed were:
libcontainer/configs/config_test.go:205:12: printf: non-constant format string in call to (*testing.common).Errorf (govet)
t.Errorf(fmt.Sprintf("Expected error to not occur but it was %+v", err))
^
libcontainer/cgroups/fs/blkio_test.go:481:13: printf: non-constant format string in call to (*testing.common).Errorf (govet)
t.Errorf(fmt.Sprintf("test case '%s' failed unexpectedly: %s", testCase.desc, err))
^
libcontainer/cgroups/fs/blkio_test.go:595:13: printf: non-constant format string in call to (*testing.common).Errorf (govet)
t.Errorf(fmt.Sprintf("test case '%s' failed unexpectedly: %s", testCase.desc, err))
^
Signed-off-by: Kir Kolyshkin <[email protected]>
|
@AkihiroSuda PTAL (helps to unblock CI) |
As of #4290, we are already prepared, so the only things left to do are:
Also, bump go to 1.22 in go.mod.
🔔 For CI, see #4375.