Skip to content

Support SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV#3862

Closed
utam0k wants to merge 1 commit intoopencontainers:mainfrom
utam0k:SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV
Closed

Support SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV#3862
utam0k wants to merge 1 commit intoopencontainers:mainfrom
utam0k:SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV

Conversation

@utam0k
Copy link
Copy Markdown
Member

@utam0k utam0k commented May 11, 2023

Fix #3860

I didn't find a good way to test SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV 😭

Fix opencontainers#3860

Signed-off-by: utam0k <k0ma@utam0k.jp>
@utam0k
Copy link
Copy Markdown
Member Author

utam0k commented May 11, 2023

crun: containers/crun#1008

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented May 11, 2023

Could you remove:

v1.1.0-rc.1 | `SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV` | TODO ([#3860](https://github.com/opencontainers/runc/issues/3860))

@AkihiroSuda AkihiroSuda added this to the 1.2.0 milestone May 11, 2023
@kolyshkin
Copy link
Copy Markdown
Contributor

I guess this needs to be

  • added to a released libseccomp version
  • added to libseccomp-golang

Once in, we can implement it in runc.

@AkihiroSuda AkihiroSuda modified the milestones: 1.2.0, 1.3.0 May 11, 2023
@utam0k
Copy link
Copy Markdown
Member Author

utam0k commented May 12, 2023

I guess this needs to be

  • added to a released libseccomp version
  • added to libseccomp-golang

Once in, we can implement it in runc.

I see. I will make this PR the draft PR once.

@utam0k utam0k marked this pull request as draft May 12, 2023 11:32
@kolyshkin
Copy link
Copy Markdown
Contributor

kolyshkin commented Jan 10, 2025

A quick status update.

For libseccomp, it looks like support for SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV / SCMP_FLTATR_CTL_WAITKILL is added in seccomp/libseccomp#387 which has 2.6.0 milestone. Indeeed, the functionality is not in a released version as of time of writing this (Jan 2025).

So this PR have to wait for:

  • libseccomp 2.6.0 release
  • libseccomp-golang release which syncs features from libseccomp 2.6.0

@kolyshkin
Copy link
Copy Markdown
Contributor

  • libseccomp 2.6.0 release

This is now DONE!

  • libseccomp-golang release which syncs features from libseccomp 2.6.0

This is being done in seccomp/libseccomp-golang#114 (there will be more PRs, and eventually a ne release).

@rata
Copy link
Copy Markdown
Member

rata commented Apr 8, 2025

Moving to 1.4 because this doesn't seem ready and it seems like a feature, that we shouldn't merge at this point for 1.3.

Don't hesitate to speak-up if you want this in 1.3 anyways.

@rata rata modified the milestones: 1.3.0, 1.4.0-rc.1 Apr 8, 2025
@kolyshkin
Copy link
Copy Markdown
Contributor

We still need libseccomp-golang release, which is more-or-less in review ATM

@cyphar cyphar modified the milestones: 1.4.0-rc.1, 1.5.0-rc.1 Aug 27, 2025
@AkihiroSuda
Copy link
Copy Markdown
Member

What is the current status?

@cyphar cyphar modified the milestones: 1.5.0-rc.1, 1.6.0-rc.1 Mar 2, 2026
['"SECCOMP_FILTER_FLAG_TSYNC"']=0 # Supported but ignored by runc, thus 0.
['"SECCOMP_FILTER_FLAG_LOG"']=2
['"SECCOMP_FILTER_FLAG_SPEC_ALLOW"']=4
['"SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV"']=7
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the value here should be 32.

@kolyshkin
Copy link
Copy Markdown
Contributor

Status update: I was trying to revamp this and hit the wall: once the new flag is enabled, our example seccompagent stops working normally. Opened a draft PR #5172 , but someone who knows more about seccomp will need to take a look.

@kolyshkin
Copy link
Copy Markdown
Contributor

Update: PR #5172 is ready for review, so we can close this one.

@kolyshkin kolyshkin closed this Mar 13, 2026
@kolyshkin kolyshkin modified the milestones: 1.6.0-rc.1, 1.5.0-rc.2 Mar 18, 2026
@kolyshkin kolyshkin removed this from the 1.5.0-rc.2 milestone Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV

5 participants