Output container ID when create container #386
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So users will always know the ID of the container. Signed-off-by: Qiang Huang <[email protected]>
Contributor
Author
|
Not sure if everyone want this, just a proposal to addresses #384 (comment) |
Contributor
|
I can't say that I fan of this, it complicates stream handling. |
Contributor
Author
Contributor
|
@hqhq Yes, I don't like this either. We shouldn't be polluting the stdout. |
Contributor
|
We should probably close this. |
Contributor
Author
|
@mrunalp Yes, let's discuss this container ID problem in a separate issue. |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Hide output dir from git
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So users will always know the ID of the container.
Signed-off-by: Qiang Huang [email protected]