libct/init_linux: retry chdir to fix EACCES (regression in rc93) #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haircommander
force-pushed
the
chdir-fix-2
branch
from
742b68e to
4f412ee
Compare
haircommander
force-pushed
the
chdir-fix-2
branch
2 times, most recently
from
84558ba to
d4c3bbf
Compare
kolyshkin
reviewed
Apr 6, 2021
haircommander
force-pushed
the
chdir-fix-2
branch
from
d4c3bbf to
a3bbcbc
Compare
haircommander
force-pushed
the
chdir-fix-2
branch
from
a3bbcbc to
763bba6
Compare
|
I think IsPermission fixes the failures |
Alas, the EPERM on chdir saga continues... Unfortunately, the there were two releases between when opencontainers@5e0e67d was released and when the workaround opencontainers#2712 was added. Between this, folks started relying on the ability to have a workdir that the container user doesn't have access to. Since this case was previously valid, we should continue support for it. Now, we retry the chdir: Once at the top of the function (to catch cases where the runc user has access, but container user does not) and once after we setup user (to catch cases where the container user has access, and the runc user does not) Add a test case for this as well. Signed-off-by: Peter Hunt <[email protected]>
haircommander
force-pushed
the
chdir-fix-2
branch
from
763bba6 to
6ce2d63
Compare
|
Ah, the
and there's no EPERM in the list of errors returned by chdir. So we could use |
|
CI on CentOS hit a snag; restarted. |
kolyshkin
changed the title
kolyshkin
reviewed
Apr 6, 2021
| case err == nil: | ||
| doChdir = false | ||
| case os.IsPermission(err): | ||
| // If we hit an EPERM, we should attempt again after setting up user. |
There was a problem hiding this comment.
this needs to mention EACCES not EPERM.
kolyshkin
approved these changes
Apr 6, 2021
mrunalp
approved these changes
Apr 7, 2021
kolyshkin
changed the title
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alas, the EPERM on chdir saga continues...
Unfortunately, the there were two releases between when 5e0e67d was released
and when the workaround #2712 was added.
Between this, folks started relying on the ability to have a workdir that the container user doesn't have access to.
Since this case was previously valid, we should continue support for it.
Now, we retry the chdir:
Once at the top of the function (to catch cases where the runc user has access, but container user does not)
and once after we setup user (to catch cases where the container user has access, and the runc user does not)
Add a test case for this as well.
Signed-off-by: Peter Hunt [email protected]