Paths nits #2472
Merged
Paths nits #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit 714c91e, method GetPaths() should only be used for saving container state. For other uses, we have a new method, Path(), which is cleaner. Fix GetPaths() usage introduced by recent commits 859a780 and 9087f2e. Signed-off-by: Kir Kolyshkin <[email protected]>
This fixes a few cases of accessing m.paths map directly without holding the mutex lock. Fixes: 9087f2e Signed-off-by: Kir Kolyshkin <[email protected]>
AkihiroSuda
approved these changes
Jun 16, 2020
mrunalp
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixup for
GetPaths()instead ofPath()m.pathsmap without lockmostly introduced by #2338 and #2391.