libcontainer: fix compilation on GOARCH=arm GOARM=6 (32 bits) #1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
I think we can just add runc/libcontainer/user/user.go Line 113 in 0e56164 |
tiborvass
force-pushed
the
fix-arm32bit
branch
2 times, most recently
from
377c69b to
6c937ad
Compare
This fixes the following compilation error on 32bit ARM: ``` $ GOARCH=arm GOARCH=6 go build ./libcontainer/system/ libcontainer/system/linux.go:119:89: constant 4294967295 overflows int ``` Signed-off-by: Tibor Vass <[email protected]>
AkihiroSuda
approved these changes
Jun 14, 2018
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM(IANAM) if green, thanks!
This was referenced Jun 15, 2018
Member
|
LGTM. |
Contributor
|
LGTM |
Contributor
Author
|
Thank you very much! |
AkihiroSuda
added a commit
to AkihiroSuda/buildkit_poc
that referenced
this pull request
Jun 15, 2018
For opencontainers/runc#1819 Signed-off-by: Akihiro Suda <[email protected]>
This was referenced Jun 15, 2018
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following compilation error on 32bit ARM:
Signed-off-by: Tibor Vass [email protected]
Related to #1688
Fixes #1818