fix panic when Linux is nil #1551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
dqminh
reviewed
Aug 10, 2017
| func setupUserNamespace(spec *specs.Spec, config *configs.Config) error { | ||
| if len(spec.Linux.UIDMappings) == 0 { | ||
| return nil | ||
| } |
Contributor
There was a problem hiding this comment.
this removal seems unintended. i think if spec.Linux is nil here we shoud just bail to be the same as the old code.
Member
Author
There was a problem hiding this comment.
The nil check should be on 613 now
Linux is not always not nil. If Linux is nil, panic will occur. Signed-off-by: Ma Shimiao <[email protected]> Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
linux-nil
branch
from
076206e to
527dc5a
Compare
Member
|
LGTM. |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux is not always not nil.
If Linux is nil, panic will occur.
Closes #1449
This is a rebase of #1449
Signed-off-by: Ma Shimiao [email protected]
Signed-off-by: Michael Crosby [email protected]