Skip to content

Commit

Permalink
libct/nsenter: relax "can't compile" conditions
Browse files Browse the repository at this point in the history
In particular, glibc >= 2.32 should be good to go, as it has commit
86ed0774cf which should fix the NULL pointer dereference in Go runtime
code.

Signed-off-by: Kir Kolyshkin <[email protected]>
  • Loading branch information
kolyshkin committed May 24, 2024
1 parent 857ceae commit b115856
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions libcontainer/nsenter/nsenter_go122.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ package nsenter
// ignore the rules in signal-safety(7), and so it's possible musl will also
// have issues, but as this is just a hotfix let's only block glibc builds.
#include <features.h>
#ifdef __GLIBC__
# error "runc does not currently work properly with Go >=1.22. See <https://github.com/opencontainers/runc/issues/4233>."
#if __GLIBC__ && !__GLIBC_PREREQ(2, 32)
# error "runc does not currently work properly with Go >=1.22 and glibc < 2.32. See <https://github.com/opencontainers/runc/issues/4233>."
#endif
*/
import "C"

0 comments on commit b115856

Please sign in to comment.