Skip to content
This repository was archived by the owner on Jan 15, 2026. It is now read-only.

Conversation

@hongchaodeng
Copy link
Contributor

@hongchaodeng hongchaodeng commented Dec 13, 2017

Signed-off-by: Hongchao Deng hongchaodeng1@gmail.com

Otherwise it will error:

cannot save image with empty image.ref.name

Ref: containers/skopeo#446

@Mashimiao
Copy link

You need to add a Signed-off-by: line to your commit

@hongchaodeng
Copy link
Contributor Author

@Mashimiao Already added but still not passed.

@Mashimiao
Copy link

That's because your commit's author is not the same as signed-off-by

@hongchaodeng
Copy link
Contributor Author

Fixed.
Thanks for your advice.

@jonboulle
Copy link
Contributor

jonboulle commented Dec 13, 2017

lgtm

Approved with PullApprove

@zhouhao3
Copy link

The same question in man folder(oci-image-tool-*.md), can you fix it together?

Otherwise it will error:
```
cannot save image with empty image.ref.name
```

Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
@hongchaodeng
Copy link
Contributor Author

fixed

@coolljt0725
Copy link
Member

coolljt0725 commented Dec 14, 2017

LGTM

Approved with PullApprove

1 similar comment
@zhouhao3
Copy link

zhouhao3 commented Dec 14, 2017

LGTM

Approved with PullApprove

@zhouhao3 zhouhao3 merged commit 5b35205 into opencontainers:master Dec 14, 2017
@hongchaodeng hongchaodeng deleted the patch-1 branch December 14, 2017 05:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants