Makefile: add gofmt and govet to test

[zhouhao3]

Signed-off-by: zhouhao [email protected]

[zhouhao3]

ping @opencontainers/image-tools-maintainers

[stevvooe]

Why would format be part of testing?

[zhouhao3]

I want to do fmt detection for the format, so I think it belongs to test, and I can also add gofmt commands in the makefile to make formatting adjustments.

[stevvooe]

Use gofmt -s -d. The output as you have it won't be very useful.

[stevvooe]

This still isn't using gofmt -d -s. Please use the correct command.

[zhouhao3]

I tried the method you mentioned, but gofmt only supports absolute paths. My idea is to use pwd to get the absolute path of image-tools, but I don't know how to remove the vendor next .
Do you have any advice?

[Mashimiao]

how about the following?

FILES = $(shell find ./ -name *.go | grep -v vendor)
OUT=$$(gofmt -s -d $(FILES)); if test -n "$${OUT}"; then echo "$${OUT}" && exit 1; fi

[zhouhao3]

I think it's good, thanks.

[zhouhao3]

ping @coolljt0725 @stevvooe

[zhouhao3]

@xiekeyang @stevvooe @coolljt0725 PTAL

[zhouhao3]

reping @opencontainers/image-tools-maintainers

[zhouhao3]

ping @coolljt0725 @stevvooe @xiekeyang @vbatts

[zhouhao3]

Bump

[zhouhao3]

@stevvooe @coolljt0725 @xiekeyang @cyphar PTAL

[coolljt0725]

why go test only cover UTDIRS = ./image/... ? the old way is to cover $(shell go list ./... | grep -v /vendor/)?

[zhouhao3]

? github.com/opencontainers/image-tools/cmd/oci-image-tool [no test files]
ok github.com/opencontainers/image-tools/image 1.120s coverage: 56.5% of statements
? github.com/opencontainers/image-tools/version [no test files]

Because only the image has the test file, this can improve efficiency.

[coolljt0725]

But I think it's better to keep the old way, because we can't make sure we will not add test file in other dir in future.

[zhouhao3]

Fine, updated.

[coolljt0725]

with this patch and I run make test, I can see

OUT=$(gofmt -s -d ./image/image_test.go ./image/descriptor.go ./image/config.go ./image/manifest_test.go ./image/index.go ./image/autodetect.go ./image/project.go ./image/layout.go ./image/doc.go ./image/manifest.go ./image/image.go ./image/walker.go ./cmd/oci-image-tool/create.go ./cmd/oci-image-tool/main.go ./cmd/oci-image-tool/unpack.go ./cmd/oci-image-tool/validate.go ./version/version.go); if test -n "${OUT}"; then echo "${OUT}" && exit 1; fi

Is this a expected output?

[zhouhao3]

Is this a expected output?

Yes.The purpose is to detect all the .go file.

[coolljt0725]

IMO, we can just output the gofmt warning if there is and output nothing if there is no format warning

[zhouhao3]

I think it should be output, just like test, the process should be displayed.

[Mashimiao]

LGTM

[stevvooe]

LGTM