Add go version requirement #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhouhao <[email protected]>
Author
Member
|
LGTM image-tool use a new feature |
stevvooe
approved these changes
Aug 31, 2017
Contributor
stevvooe
left a comment
stevvooe
left a comment
There was a problem hiding this comment.
Any reason not to take this up to 1.8 or 1.9?
Contributor
|
archive/tar changes significantly in 1.9, which needed some fixes in docker
IIRC (detail here: moby/moby#33935/). I don't know
if I'm really beaten by this myself, but it'd ease my mind a little if we
could at least limit it to 1.8 and up.
…On Wed, Aug 30, 2017 at 6:08 PM, Stephen Day ***@***.***> wrote:
***@***.**** approved this pull request.
Any reason not to take this up to 1.8 or 1.9?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#158 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABJ67qVROVxaUMgTNaYkUaTTPod_Ezzks5sdgd2gaJpZM4OQYoM>
.
|
Contributor
|
Sorry I misread the point of this PR I think.
…On Wed, Aug 30, 2017 at 6:12 PM, Erik Hollensbe ***@***.***> wrote:
archive/tar changes significantly in 1.9, which needed some fixes in
docker IIRC (detail here: moby/moby#33935/). I
don't know if I'm really beaten by this myself, but it'd ease my mind a
little if we could at least limit it to 1.8 and up.
On Wed, Aug 30, 2017 at 6:08 PM, Stephen Day ***@***.***>
wrote:
> ***@***.**** approved this pull request.
>
> Any reason not to take this up to 1.8 or 1.9?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#158 (review)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AABJ67qVROVxaUMgTNaYkUaTTPod_Ezzks5sdgd2gaJpZM4OQYoM>
> .
>
|
Author
I will go to find the relevant content, if necessary, I will be in the next PR to modify. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through .travis.yml know to use a go 1.7 and above, and go don't use GO15VENDOREXPERIMENT since 1.7
Signed-off-by: zhouhao [email protected]