This repository was archived by the owner on Jan 15, 2026. It is now read-only.
update annotations #152
Closed
update annotations #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Member
|
LGTM Edit: before merging this, we need update the image-spec to rc6 |
|
Please rebase. |
|
@0x0916 Please rebase. |
commit opencontainers/image-spec@8ec42b7 namespce annotations. This patch s/org.opencontainers.ref.name/org.opencontainers.image.ref.name/ Signed-off-by: 0x0916 <[email protected]>
0x0916
force-pushed
the
2017-06-22/annoations
branch
from
bf884d4 to
dc60863
Compare
Author
|
@q384566678 rebase done. |
|
LGTM |
Member
|
Was this not already handled by #163 and the other post-rc6 bumps? Needs rebase, btw. |
|
@0x0916 rebase please. |
Merged
wking
reviewed
Jul 27, 2017
| if index.Manifests[i].Annotations["org.opencontainers.ref.name"] != "" { | ||
| refs[index.Manifests[i].Annotations["org.opencontainers.ref.name"]] = &index.Manifests[i] | ||
| if index.Manifests[i].Annotations["org.opencontainers.image.ref.name"] != "" { | ||
| refs[index.Manifests[i].Annotations["org.opencontainers.image.ref.name"]] = &index.Manifests[i] |
Contributor
There was a problem hiding this comment.
Since #163 bumped image-spec to 1.0.0, you can use AnnotationRefName instead of a string literal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit opencontainers/image-spec@8ec42b7 namespce
annotations.
This patch does
s/org.opencontainers.ref.name/org.opencontainers.image.ref.name/Signed-off-by: 0x0916 [email protected]