Skip to content
This repository was archived by the owner on Jan 15, 2026. It is now read-only.

vendor: update image-spec to rc6 #150

Merged
stevvooe merged 1 commit into from
Jul 13, 2017
Merged

vendor: update image-spec to rc6 #150

stevvooe merged 1 commit into from
Jul 13, 2017

Conversation

@zhouhao3
Copy link

@zhouhao3 zhouhao3 commented Jun 2, 2017

Signed-off-by: zhouhao [email protected]

@zhouhao3 zhouhao3 changed the title vendor: update to image-spec rc6 vendor: update image-spec to rc6 Jun 2, 2017
@zhouhao3 zhouhao3 force-pushed the up-image-spec branch 2 times, most recently from 70c94b4 to 3b19bf7 Compare June 21, 2017 02:02
@zhouhao3
Copy link
Author

zhouhao3 commented Jun 21, 2017

@cyphar @stevvooe @vbatts @coolljt0725 @jonboulle PTAL.

@zhouhao3
Copy link
Author

zhouhao3 commented Jun 22, 2017

@opencontainers/image-tools-maintainers I think I need to get some response.

@coolljt0725
Copy link
Member

coolljt0725 commented Jun 22, 2017

should we make sure that image-tool work with rc5 well and then we release a image-tool, after that we update the image-spec to rc6 ?

@zhouhao3
Copy link
Author

zhouhao3 commented Jun 22, 2017

should we make sure that image-tool work with rc5 well and then we release a image-tool, after that we update the image-spec to rc6 ?

I think it is basically in line with rc5, only one validation of index, which I think will be more convenient after rc6. I think some of the verification (including imageLayout) in the update to rc6 will be better implemented.

@zhouhao3
Copy link
Author

zhouhao3 commented Jul 11, 2017

@coolljt0725 @xiekeyang @cyphar @vbatts @stevvooe Image-tool has been released v0.2.0 version, can be updated to rc6?

@zhouhao3
Copy link
Author

zhouhao3 commented Jul 13, 2017

re-ping @opencontainers/image-tools-maintainers.

@xiekeyang
Copy link
Contributor

xiekeyang commented Jul 13, 2017

I think it is OK, what other maintainers think?

@coolljt0725
Copy link
Member

coolljt0725 commented Jul 13, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

1 similar comment
@stevvooe
Copy link
Contributor

stevvooe commented Jul 13, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@stevvooe stevvooe merged commit 91950f9 into opencontainers:master Jul 13, 2017
@zhouhao3 zhouhao3 deleted the up-image-spec branch July 14, 2017 01:17
@xiekeyang xiekeyang mentioned this pull request Sep 8, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhouhao3 @coolljt0725 @xiekeyang @stevvooe