Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: use Go's embed package instead of esc #885

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

stevvooe
Copy link
Contributor

@stevvooe stevvooe commented Dec 2, 2021

Signed-off-by: Stephen Day [email protected]

@@ -1,18 +1,14 @@
module github.com/opencontainers/image-spec

go 1.11
go 1.16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm okay with this because we just cut a release that older versions of go can continue to use, but I can imagine this being controversial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good call out but is a requirement to use go:embed. If we don't want to move the req up to 1.16, we should leave esc in place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a spot check of dependencies and it looks like most are 1.16, some at 1.17, but there are some projects still at 1.14 and 1.15. Given that 1.15 is no longer officially supported by the Go, I'm okay with this myself.

@vbatts
Copy link
Member

vbatts commented Dec 9, 2021

This looks good to me, but let's hold as I don't doubt some projects are still supporting older than go1.16 versions out there.

@stevvooe
Copy link
Contributor Author

stevvooe commented Dec 9, 2021

What horizon do want to maintain here? That's probably a very large question. ;)

@AkihiroSuda
Copy link
Member

@cyphar PTAL

@vbatts
Copy link
Member

vbatts commented Feb 24, 2022

since any changes here would still eventually need to be tagged for a release, I think having a trailing number of go releases is good. Currently go1.18 is about to be released. So bumping to go1.16 would mean 3 versions of go, which is likely suitable. And maybe by the time this would get tagged to a release for image-spec, there may be another release out by then?
More important than just this PR, would be to have a small policy stating best effort that our go sources are compatible with the past few golang versions.

@sudo-bmitch
Copy link
Contributor

More important than just this PR, would be to have a small policy stating best effort that our go sources are compatible with the past few golang versions.

+100. Rather than waiting for the long tail to be cleaned up, a policy of a 3-4 supported releases sounds good to me. We aren't breaking existing projects since they can continue to use old image-spec tags. And the versions of Go they are running aren't supported by the Go developers.

@stevvooe
Copy link
Contributor Author

stevvooe commented Mar 1, 2022

@sudo-bmitch @vbatts Ok, sounds like we'll hold off on merging this until 1.18 is released.

I've added #899 to cover the need for supported versions.

Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get a follow-up PR with words on perhaps at least supporting the last three go releases

@vbatts vbatts merged commit 8205360 into opencontainers:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants