schema/validator: Punt sha256/sha512 hex-validation to go-digest #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
force-pushed
the
go-digest-unsupported
branch
from
c1ce45f to
fa09f5b
Compare
It's covered this since opencontainers/go-digest@4ca13015 (disallow upper characters (/A-F/) in hex-encoded portion, 2017-05-12, opencontainers#34), so we don't need to do it locally. Also, use a more specific check for ignoring unrecognized algorithms, because we don't want to return nil when go-digest notices an invalid encoding, etc. Signed-off-by: W. Trevor King <[email protected]>
Contributor
|
LGTM Wow, that code was wrong before. |
Member
|
since go-digest is under the oci org then it seems fine to delegate this check. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's covered this since opencontainers/go-digest#34, so we don't need to do it locally. Also, use a more specific check for ignoring unrecognized algorithms, because we don't want to return nil when go-digest notices an invalid encoding, etc.
This fixes issues like this:
which have been affecting recent unit tests on unrelated PRs.