fix bug: config test cases MUST include all required fields #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiekeyang <[email protected]>
wking
reviewed
Nov 19, 2016
| "architecture": "amd64", | ||
| "os": 123 | ||
| "os": 123, | ||
| "rootfs": { |
Contributor
There was a problem hiding this comment.
This one (and a few others) is still missing architecture and os.
Contributor
Author
There was a problem hiding this comment.
This one (and a few others) is still missing architecture and os.
Excuse me I might not understand your comment. architecture and os seems have been added to all cases.
Contributor
There was a problem hiding this comment.
Ah, sorry, I'm just blind. ceb8cf8 looks good to me.
Contributor
Author
xiekeyang
changed the title
xiekeyang
changed the title
xiekeyang
changed the title
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases should contain required fields, otherwise result will be always failure whether the validated field be legal or not. That is not our expection.
And add a new test case for only required fields, to check the
optionalandrequiredfields in spec.Signed-off-by: xiekeyang [email protected]