image-layout: organize for anchors #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonboulle
previously requested changes
Oct 28, 2016
image-layout.md
Outdated
| In the wild you often see "tags" like "v1.0.0-vendor.0", "2.0.0-debug", etc. | ||
| Those tags will often be represented in an image-layout repository with matching refs names like "v1.0.0-vendor.0", "2.0.0-debug", etc. | ||
|
|
||
| This illustrates the expected contents of a given ref, the manifest list it points to and the blobs the manifest references. |
Contributor
There was a problem hiding this comment.
could you move this below Example Ref
vbatts
force-pushed
the
image-layout_anchors
branch
from
7fbd96b to
fd3ba33
Compare
wking
reviewed
Oct 28, 2016
| {"size": 4096, "digest": "sha256:e692418e4cbaf90ca69d05a66403747baa33ee08806650b51fab815ad7fc331f", "mediatype": "application/vnd.oci.image.manifest.list.v1+json"} | ||
| ``` | ||
|
|
||
| This illustrates the expected contents of a given ref, the manifest list it points to and the blobs the manifest references. |
Contributor
There was a problem hiding this comment.
Looking at this line more closely after it was shifted, what is it actually saying? “contents of a given ref” sounds like “a descriptor”, so ok. “the manifest list it points to” might be the descriptor again. But how is this illustrating “thte blobs the manifest references”? Maybe we should drop this line entirely.
Contributor
Member
Author
There was a problem hiding this comment.
Separate concern from this PR
Contributor
|
lgtm |
Member
Author
|
@opencontainers/image-spec-maintainers PTAL |
Contributor
|
LGTM |
Contributor
|
sorry, rebase time |
vbatts
force-pushed
the
image-layout_anchors
branch
from
fd3ba33 to
73e8dc6
Compare
Member
Author
|
updated. PTAL |
Contributor
|
LGTM |
Contributor
|
lgtm |
Member
Author
|
interesting. @stevvooe's LGTM didn't work? @caniszczyk ? |
Contributor
|
LGTM |
Contributor
|
@vbatts Rebase! |
Signed-off-by: Vincent Batts <[email protected]>
vbatts
force-pushed
the
image-layout_anchors
branch
from
73e8dc6 to
bbbaa25
Compare
Member
Author
|
rebased! |
Contributor
|
lgtm |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vincent Batts [email protected]