layer.md: Fix some typo #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
reviewed
Sep 18, 2016
| If the file path is a directory, then the existing path just has it's attribute set from the layer changeset for that filepath. | ||
| If the file path is any other file type (regular file, FIFO, etc), then the: | ||
| If the file path is any other file type (regular file, FIFO, etc), then: | ||
| * file path is unlinked (See [`unlink(2)`](http://linux.die.net/man/2/unlink)) |
Contributor
There was a problem hiding this comment.
+1 to removing “the”, but we should also rephrase this to an imperative:
unlink the file path (…)
But this section is getting overhauled in #317, so it may not be worth the trouble of fixing it here ;).
Author
There was a problem hiding this comment.
@wking I have removed modification you mentioned. PTAL.
Contributor
|
ff1291c looks good to me, but it would be easier to identify this
change in the logs if the commit message were something like:
layer: Fix "an copy" -> "a copy" typo
|
Signed-off-by: Ling FaKe <[email protected]>
Author
|
@wking thanks for you suggestion. It is OK. PTAL |
Contributor
|
Looks great, thanks :) |
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ling FaKe [email protected]