Skip to content

Conversation

@coolljt0725
Copy link
Member

Signed-off-by: Lei Jitang [email protected]

@philips
Copy link
Contributor

philips commented Sep 1, 2016

id_desc doesn't exist either.

layer.md Outdated

An image root filesystem is first created as an empty directory.
Here is the initial empty directory structure for the a changeset using the randomly-generated directory name `c3167915dc9d` ([actual layer DiffIDs are generated based on the content](#id_desc)).
Here is the initial empty directory structure for the a changeset using the randomly-generated directory name `c3167915dc9d` ([actual layer DiffIDs are generated based on the content](#serialization.md#terminology)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#serialization.md#terminologyserialization.md#terminology

@wking
Copy link
Contributor

wking commented Sep 1, 2016

On Thu, Sep 01, 2016 at 05:56:19AM -0700, Brandon Philips wrote:

id_desc doesn't exist either.

The serialization file's “Terminology” section does define “Layer
DiffID”, so I think linking to that section is fine.

@coolljt0725 coolljt0725 force-pushed the fix_id_desc branch 2 times, most recently from 76f4ebe to 5e90c57 Compare September 5, 2016 06:46
@coolljt0725
Copy link
Member Author

@philips serialization.md#terminology has description of layer DiffIDs, so I think it's ok to link to there

@coolljt0725 coolljt0725 force-pushed the fix_id_desc branch 2 times, most recently from 212bc9f to 247ae73 Compare September 5, 2016 11:40
Signed-off-by: Lei Jitang <[email protected]>
@jonboulle
Copy link
Contributor

This is addressed in #255 which is being actively worked on now so I think we should just defer to there.

@jonboulle jonboulle closed this Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants