Export types #172
Merged
Export types #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Murdaca <[email protected]>
specs-go/versioned.go
Outdated
|
|
||
| package specs | ||
|
|
||
| // Versioned provides a struct with the manifest schemaVersion and . Incoming |
Contributor
There was a problem hiding this comment.
“and . Incoming” is probably a typo. Maybe you meant “schemaVersion and mediaType. Incoming”?
Signed-off-by: Antonio Murdaca <[email protected]>
Member
|
as a first pass, this |
Contributor
|
LGTM on first pass. |
Member
|
cool. i'll merge this and we can iterate on it. |
This was referenced Jul 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @vbatts @stevvooe @philips
This is another version #147 w/o using any code generation tool - as discussed over there
Close #147