Skip to content

Conversation

@philips
Copy link
Contributor

@philips philips commented Jun 7, 2016

Based on feedback new users might not know what the base and optional
layer language is about. Point to the scope doc that uses this language.
Fixes #120.

Signed-off-by: Brandon Philips [email protected]

README.md Outdated
* Signatures that are based on signing image content address (optional layer)
* Naming that is federated based on DNS and can be delegated (optional layer)

The optional and base layers of all OCI projects are tracked in the OCI Scope Table](https://www.opencontainers.org/governance/oci-scope-table).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“OCI” → “[OCI”

Based on feedback new users might not know what the base and optional
layer language is about. Point to the scope doc that uses this language.
Fixes opencontainers#120.

Signed-off-by: Brandon Philips <[email protected]>
@philips philips force-pushed the clarify-base-optional-layers branch from 485be94 to 6b4694f Compare June 7, 2016 23:07
@philips
Copy link
Contributor Author

philips commented Jun 7, 2016

LGTM

Approved with PullApprove

@philips philips added this to the v1.0.0-rc milestone Jun 7, 2016
@philips
Copy link
Contributor Author

philips commented Jun 8, 2016

@opencontainers/image-spec-maintainers any other LGTMs for this trivial change?

@stevvooe
Copy link
Contributor

stevvooe commented Jun 9, 2016

LGTM

Approved with PullApprove

@stevvooe
Copy link
Contributor

stevvooe commented Jun 9, 2016

@philips Does this tool allow you to LGTM your self?

@philips
Copy link
Contributor Author

philips commented Jun 9, 2016

@stevvooe yes, if you are a maintainer you can LGTM yourself.

@philips
Copy link
Contributor Author

philips commented Jun 9, 2016

@stevvooe but the threshold is two maintainers to merge so need one more.

@philips philips merged commit 361950c into opencontainers:master Jun 9, 2016
@wking
Copy link
Contributor

wking commented Jun 9, 2016

On Wed, Jun 08, 2016 at 05:47:08PM -0700, Brandon Philips wrote:

@stevvooe yes, if you are a maintainer you can LGTM yourself.

Currently only in this repo of the OCI repos using PullApprove
(opencontainers/project-template#13, opencontainers/runtime-spec#474,
opencontainers/runc#863).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants