Hard link limitations in union filesystems #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-bmitch
requested review from
jonjohnsonjr,
stevvooe,
sajayantony,
tianon and
cyphar
as code owners
tianon
previously approved these changes
Oct 25, 2024
sajayantony
reviewed
Nov 7, 2024
layer.md
Outdated
| @@ -69,6 +69,8 @@ Where supported, MUST include file attributes for Additions and Modifications in | |||
| - Non-directory files are considered "hardlinked" when their link count is greater than 1. | |||
| - Hardlinked files are on a same device (i.e. comparing Major:Minor pair) and have the same inode. | |||
| - The corresponding files that share the link with the > 1 linkcount may be outside the directory that the changeset is being produced from, in which case the `linkname` is not recorded in the changeset. | |||
| - Union filesystem implementations may have limited or no support for hardlinks, particularly when a change is made to a hardlinked file or a hardlink is created to a file in a lower filesystem. | |||
There was a problem hiding this comment.
Do you want to include this link? - https://docs.kernel.org/filesystems/overlayfs.html#index
Might be worth if or when someone revisits this section.
There was a problem hiding this comment.
Okay, I've included that.
Signed-off-by: Brandon Mitchell <[email protected]>
sudo-bmitch
force-pushed
the
pr-cross-layer-hardlink
branch
from
3e817a4 to
03306ac
Compare
tianon
approved these changes
Nov 8, 2024
jonjohnsonjr
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1204.
This calls out the limitations of hard links in a union filesystem. E.g. in some configurations a hard link may be broken when multiple files are hard linked and a change is made to one file or a hard link is created to a lower filesystem file. See https://docs.kernel.org/filesystems/overlayfs.html#index