-
Notifications
You must be signed in to change notification settings - Fork 804
Fix the PullApprove approve_regex to cover more cases #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the PullApprove approve_regex to cover more cases #106
Conversation
'^(Approved|lgtm|LGTM|:shipit:|:star:|:\+1:|:ship:)' Signed-off-by: Chris Aniszczyk <[email protected]>
1 similar comment
|
@caniszczyk is this some new build integration you did that is failing now?! |
|
On Wed, Jun 01, 2016 at 01:13:11PM -0700, Brandon Philips wrote:
git-validation is old, and that's what's complaining 1. @vbatts? |
|
sorry at a conference where the wifi is equivalent of a 28k modem, not sure why it's failing |
|
On Wed, Jun 01, 2016 at 01:14:44PM -0700, W. Trevor King wrote:
Looks like a bug in Travis, with a workaround being to have more than |
|
@wking thanks, going to push another commit to the PR and see if that does it |
|
@caniszczyk hold on that. See #107 |
|
see #108 |
'^(Approved|lgtm|LGTM|:shipit:|:star:|:+1:|:ship:)'
Signed-off-by: Chris Aniszczyk [email protected]