Skip to content

Conversation

@caniszczyk
Copy link
Contributor

'^(Approved|lgtm|LGTM|:shipit:|:star:|:+1:|:ship:)'

Signed-off-by: Chris Aniszczyk [email protected]

'^(Approved|lgtm|LGTM|:shipit:|:star:|:\+1:|:ship:)'

Signed-off-by: Chris Aniszczyk <[email protected]>
@philips
Copy link
Contributor

philips commented Jun 1, 2016

LGTM

Approved with PullApprove

1 similar comment
@jonboulle
Copy link
Contributor

jonboulle commented Jun 1, 2016

LGTM

Approved with PullApprove

@philips
Copy link
Contributor

philips commented Jun 1, 2016

@caniszczyk is this some new build integration you did that is failing now?!

@wking
Copy link
Contributor

wking commented Jun 1, 2016

On Wed, Jun 01, 2016 at 01:13:11PM -0700, Brandon Philips wrote:

@caniszczyk is this some new build integration you did that is failing now?!

git-validation is old, and that's what's complaining 1. @vbatts?

@caniszczyk
Copy link
Contributor Author

sorry at a conference where the wifi is equivalent of a 28k modem, not sure why it's failing

@wking
Copy link
Contributor

wking commented Jun 1, 2016

On Wed, Jun 01, 2016 at 01:14:44PM -0700, W. Trevor King wrote:

git-validation is old, and that's what's complaining 1. @vbatts?

1: https://travis-ci.org/opencontainers/image-spec/builds/134561897#L236

Looks like a bug in Travis, with a workaround being to have more than
one commit in the PR 1.

@caniszczyk
Copy link
Contributor Author

@wking thanks, going to push another commit to the PR and see if that does it

@vbatts
Copy link
Member

vbatts commented Jun 1, 2016

@caniszczyk hold on that. See #107

@caniszczyk
Copy link
Contributor Author

@vbatts I just created another PR that will solve our problem #108

@caniszczyk
Copy link
Contributor Author

see #108

@caniszczyk caniszczyk closed this Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants