Add handling of unknown fields to conformance tests #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
requested review from
dmcgowan,
jdolitsky,
jonjohnsonjr,
jzelinskie,
mikebrow,
stevvooe and
vbatts
as code owners
This change also removes the direct dependency on Go types defined in the image-spec repo, since this made it difficult to define new fields. Instead, the types are copied into this repo and modified to remove unused fields, and add a new unspecified field for use in the test. Signed-off-by: Jason Hall <[email protected]>
imjasonh
force-pushed
the
conformance-unknown-fields
branch
from
f2548ed
to
5de2081
Compare
jdolitsky
approved these changes
Dec 1, 2021
jonjohnsonjr
approved these changes
Dec 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also removes the direct dependency on Go types defined in
the image-spec repo, since this made it difficult to define new fields.
Instead, the types are copied into this repo and modified to remove
unused fields, and add a new unspecified field for use in the test.
Signed-off-by: Jason Hall [email protected]
Note: I haven't run this against any real registries yet, I wanted to get feedback about the general direction before proceeding too much further.
cc @jdolitsky our beloved conformance czar 👑