Add conformance test verifying that cross-repo mount fails "open" #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sargun
requested review from
dmcgowan,
jdolitsky,
jonjohnsonjr,
jzelinskie,
mikebrow,
stevvooe and
vbatts
as code owners
conformance/02_push_test.go
Outdated
| resp, err := client.Do(req) | ||
| Expect(err).To(BeNil()) | ||
| Expect(resp.StatusCode()).To(Equal(http.StatusAccepted)) | ||
| Expect(resp.GetRelativeLocation()).To(ContainSubstring(crossmountNamespace)) |
There was a problem hiding this comment.
I think this is not strictly necessary (though I see it in the next case as well :/). The location header may point to an external service which might not include the namespace in the URL. I think we mostly just want to ensure Location is non-empty.
In opencontainers#281, we stated that cross-repo mounts without from should start an upload. This is a requirement to make it so that clients can adopt the changes in opencontainers#275 smoothly. Signed-off-by: Sargun Dhillon <[email protected]>
sargun
force-pushed
the
add-conformance-for-push
branch
from
544cc0f
to
9173aad
Compare
jonjohnsonjr
previously approved these changes
Sep 15, 2021
sargun
force-pushed
the
add-conformance-for-push
branch
from
d8fa0ee
to
9173aad
Compare
jonjohnsonjr
approved these changes
Sep 16, 2021
jdolitsky
approved these changes
Sep 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #281, we stated
that cross-repo mounts without from should start an upload. This is a
requirement to make it so that clients can adopt the changes in
#275 smoothly.
Signed-off-by: Sargun Dhillon [email protected]