Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CODEOWNERS #286

Merged
merged 3 commits into from
Jun 23, 2021
Merged

Add CODEOWNERS #286

merged 3 commits into from
Jun 23, 2021

Conversation

jzelinskie
Copy link
Member

This will allow us to use GitHub to enforce approvals rather than an outside CI system like pullapprove.

@jzelinskie
fix my email
82ce0ac 
Signed-off-by: Jimmy Zelinskie <[email protected]>
@jzelinskie
add CODEOWNERS
bb5ddab 
Signed-off-by: Jimmy Zelinskie <[email protected]>
@jzelinskie
remove pullapprove
3f766f4 
Signed-off-by: Jimmy Zelinskie <[email protected]>
vbatts
vbatts approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even tho the OP has a wrong PR subject, we can roll with these changes.
I'll enable the CODEOWNERs for main branch.

@jzelinskie jzelinskie merged commit e632d5a into main Jun 23, 2021
@jzelinskie jzelinskie deleted the codeowners branch June 23, 2021 22:02
@jdolitsky jdolitsky mentioned this pull request Sep 15, 2022
Merged
@sudo-bmitch sudo-bmitch mentioned this pull request Feb 1, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdolitsky jdolitsky jdolitsky approved these changes

@vbatts vbatts vbatts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzelinskie @vbatts @jdolitsky