Skip to content

ci: add nolintlint, fix warnings #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kolyshkin merged 1 commit into from
Apr 23, 2025
Merged

ci: add nolintlint, fix warnings #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@

linters:
enable:
- gofumpt
- errorlint
- gofumpt
- nolintlint
- unconvert
- unparam

Expand Down
2 changes: 1 addition & 1 deletion fscommon/rdma.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func readRdmaEntries(dir, file string) ([]cgroups.RdmaEntry, error) {
if err != nil {
return nil, err
}
defer fd.Close() //nolint:errorlint
defer fd.Close()
scanner := bufio.NewScanner(fd)
for scanner.Scan() {
parts := strings.SplitN(scanner.Text(), " ", 4)
Expand Down
2 changes: 1 addition & 1 deletion utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ func rmdir(path string, retry bool) error {

again:
err := unix.Rmdir(path)
switch err { // nolint:errorlint // unix errors are bare
switch err {
case nil, unix.ENOENT:
return nil
case unix.EINTR:
Expand Down