Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for unmarshalling gNMI TypedValue #252

Merged
merged 3 commits into from
Nov 6, 2018
Merged

Conversation

g-yusufsn
Copy link
Contributor

Change includes;

  • Adding unmarshalling support for gNMI TypedValue
  • Modifying retriveNode to use unmarshalGeneric function to unmarshal gNMI TypedValues
  • Fixing a bug where we should return an error in SetNode if path points to a non-leaf schema

@g-yusufsn g-yusufsn requested a review from robshakir November 2, 2018 17:24
@coveralls
Copy link

coveralls commented Nov 2, 2018

Coverage Status

Coverage decreased (-0.06%) to 91.107% when pulling 50247c7 on unmarshal-gnmi into d19e6ae on master.

@g-yusufsn
Copy link
Contributor Author

I guess we are broken due to grpc/grpc-go#2428. We need to remove it from the list of go versions we are building against.

@robshakir
Copy link
Contributor

robshakir commented Nov 3, 2018 via email

@g-yusufsn
Copy link
Contributor Author

I just created PR and sent to you. Feel free to review whenever you have time. Thanks for the reply!

#254

Copy link
Contributor

@robshakir robshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change!

@robshakir robshakir merged commit a2767ca into master Nov 6, 2018
@robshakir robshakir deleted the unmarshal-gnmi branch November 6, 2018 03:18
@g-yusufsn
Copy link
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants