Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated UDP enums related to openconfig-aft-types. #1248

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Updated UDP enums related to openconfig-aft-types. #1248

wants to merge 8 commits into from

Conversation

tengyiG
Copy link
Contributor

@tengyiG tengyiG commented Jan 23, 2025

Change Scope

  • Added UDPV4 and UDPV6 while keeping enums of UDP for backward compatibility.
  • Yes, I kept the UDP enum.

@tengyiG tengyiG requested a review from a team as a code owner January 23, 2025 21:38
dplore
dplore requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to bump the version to 1.3.0 here:

https://github.com/openconfig/public/pull/1248/files#diff-fefb9524b37f8f5c6637274d1eaa085ac01e294c5b3bf02ef8e4d37a12cba43bR19

release/models/aft/openconfig-aft-types.yang Outdated Show resolved Hide resolved
@dplore
Copy link
Member

dplore commented Jan 28, 2025

/gcbrun

@OpenConfigBot
Copy link

OpenConfigBot commented Jan 28, 2025 •
edited
Loading

No major YANG version changes in commit 7147dec

@dplore
Copy link
Member

dplore commented Jan 28, 2025

/gcbrun

@dplore
Copy link
Member

dplore commented Jan 28, 2025

/gcbrun

@dplore
Copy link
Member

dplore commented Jan 29, 2025

/gcbrun

@tengyiG tengyiG requested a review from dplore January 29, 2025 00:20
@dplore
Copy link
Member

dplore commented Jan 29, 2025

Thanks for this. This is essentially a bug fix as it was always intended to have UDPV4 and UDPV6 enums here. I will merge this on Feb 4th, pending OC Operator review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplore dplore Awaiting requested review from dplore

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
non-breaking
Projects
OC Operator Review
Status: last-call
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tengyiG @dplore @OpenConfigBot