fix(swiftformat): sync GatewayModels exclusions with OpenClawProtocol - #41242
Merged
thewilloftheshadow merged 3 commits intoMar 10, 2026
Merged
Conversation
Contributor
Greptile SummaryThis PR fixes two stale formatter/linter exclusions that still referenced the old Key findings:
Confidence Score: 5/5
Last reviewed commit: 6e02949 |
aiwatching
pushed a commit
to aiwatching/openclaw
that referenced
this pull request
Mar 10, 2026
…openclaw#41242) Co-authored-by: Shadow <shadow@openclaw.ai>
Moshiii
pushed a commit
to Moshiii/openclaw
that referenced
this pull request
Mar 11, 2026
…openclaw#41242) Co-authored-by: Shadow <shadow@openclaw.ai>
Moshiii
pushed a commit
to Moshiii/openclaw
that referenced
this pull request
Mar 11, 2026
…openclaw#41242) Co-authored-by: Shadow <shadow@openclaw.ai>
Ruijie-Ysp
pushed a commit
to Ruijie-Ysp/clawdbot
that referenced
this pull request
Mar 12, 2026
…openclaw#41242) Co-authored-by: Shadow <shadow@openclaw.ai>
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
…openclaw#41242) Co-authored-by: Shadow <shadow@openclaw.ai>
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
…openclaw#41242) Co-authored-by: Shadow <shadow@openclaw.ai>
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
…openclaw#41242) Co-authored-by: Shadow <shadow@openclaw.ai>
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 24, 2026
…openclaw#41242) Co-authored-by: Shadow <shadow@openclaw.ai>
vixco
pushed a commit
to vixco/openclaw
that referenced
this pull request
Aug 16, 2026
…openclaw#41242) Co-authored-by: Shadow <shadow@openclaw.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-assisted: yes (Cursor). Testing: lightly tested.
Summary
.swiftformatand.swiftlint.ymlstill excludeapps/macos/Sources/MoltbotProtocol/..., but the generated Swift protocol models now live underapps/macos/Sources/OpenClawProtocol/....GatewayModels.swiftfile, so formatter/linter runs can drift away from the current generated-file path again.apps/macos/Sources/OpenClawProtocol/GatewayModels.swift.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
None.
Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
mainSteps
mainforGatewayModels.swiftreferences and generated-file paths.MoltbotProtocolwas introduced during the earlier macOS rename work, then verify the laterrefactor: rename to openclawmove changed the generated file path history toOpenClawProtocol.MoltbotProtocolpath.Expected
apps/macos/Sources/OpenClawProtocol.MoltbotProtocolexclusion should remain forGatewayModels.swift.Actual
apps/macos/Sources/OpenClawProtocol/GatewayModels.swift.Evidence
Attach at least one:
Trace/history used for verification:
apps/macos/Sources/ClawdbotProtocoltoapps/macos/Sources/MoltbotProtocoland updated.swiftformat/.swiftlint.ymlas part of that change.9a71607(refactor: rename to openclaw) is the path transition point whereapps/macos/Sources/MoltbotProtocol/GatewayModels.swifthistory moves toapps/macos/Sources/OpenClawProtocol/GatewayModels.swift.MoltbotProtocolonly in these two exclusion configs, while generator/package/docs/test references already useOpenClawProtocol.Human Verification (required)
What you personally verified (not just CI), and how:
MoltbotProtocolvsOpenClawProtocol; local diff only changes the two stale exclusions..swiftformatexcludes the whole generated protocol directory, while.swiftlint.ymlexcludes the specific generated file; both now align with the current path.pnpm format:swift/pnpm lint:swiftexecution, because this environment does not have theswiftformatandswiftlintbinaries installed.Review Conversations
If a bot review conversation is addressed by this PR, resolve that conversation yourself. Do not leave bot review conversation cleanup for maintainers.
Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
.swiftformat,.swiftlint.ymlRisks and Mitigations
MoltbotProtocolin these two config entries; generator, package, docs, and test references already point toOpenClawProtocol.Made with Cursor