docs(path): explain the Bun Rust resolver choice - #325
Merged
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The Bun resolver comments did not explain why its workaround uses the existing Rust addon or why disabling that addon restores Bun's upstream limitations.
Why This Change Was Made
Document the N-API choice beside the resolver: it works with JIT disabled and avoids a separate FFI bridge for native loading and memory handling. Clarify that native mode
offdisables the workaround because it belongs to the same optional addon.User Impact
Source comments only; runtime behavior and public contracts are unchanged. Follows #324. No changelog entry is needed for this explanatory follow-up.
Evidence
Every non-comment line is identical to the merged implementation.
git diff --checkpasses. The implementation's passing Node/Bun checks, platform CI, and stress evidence remain recorded in #324; this comment-only change does not invalidate that proof.