Skip to content

fix(cli): port Node alias, argv, and worker startup fixes - #31

Merged
steipete merged 6 commits into
mainfrom
claude/port-ci-cli-process
Sep 30, 2026
Merged

steipete merged 6 commits into
mainfrom
claude/port-ci-cli-process

Conversation

@steipete

@steipete steipete commented Sep 30, 2026 •

Copy link
Copy Markdown

Port Node-alias stdin/eval/version behavior, lexical process.argv entry paths, and cleanup of transferred ports after worker startup fails. These preserve the CLI and worker contracts used by OpenClaw tooling. Child-process ports that overlap #28 remain separate.

Original authors and cherry-pick provenance are retained as individual commits.

CI source Fork commit Fix Upstream PR/state
ac9be0270f c513ef4102 fix(cli): run bare input-type from stdin #43068 OPEN
bc863b1454 d094a8c665 fix(cli): preserve eval arguments through the node alias #43270 OPEN
2e3ce72503 6d762b43e6 fix(cli): handle Node alias version queries and stdin #43301 OPEN (narrower scope)
0438136097 472d2b109d fix(node): preserve lexical entry paths in process.argv #43347 OPEN
7092960ef6 69b83cdabf fix(worker_threads): close ports when worker startup fails #43222 CLOSED
d7a36f88cc 1867ab09c9 test(worker_threads): cover startup workerData ports #43222 CLOSED

Qualified together with the complete independent stack on darwin-arm64 at 828fba48faa28a56f15839c79f1c6d6838dd8405 using bun scripts/build.ts --profile=release, linked to unchanged WebKit f20ce7744553c910bcf16a33faf976af208de091. The release binary’s revision was verified before tests.

BUN_FEATURE_FLAG_INTERNAL_FOR_TESTING=1 BUN_GARBAGE_COLLECTOR_LEVEL=0 build/release/bun test <file> --max-concurrency 2

Test file Pass Skip Todo Fail
test/bundler/compile-argv.test.ts 15 0 0 0
test/cli/run/as-node.test.ts 48 0 0 0
test/cli/run/run-eval.test.ts 65 0 0 0
test/js/node/process/process-args.test.js 46 2 0 0
test/js/node/worker_threads/worker_threads.test.ts 174 0 0 0

Independent Codex review found no actionable P0/P1 findings. Local JavaScript lint and Rust/C++/TypeScript formatting checks passed. Cross-target Rust checking passed all 12 targets with release codegen inputs (0 failed, 0 skipped). No workflow or WebKit-pin changes.

@steipete
steipete force-pushed the claude/port-ci-plugins branch from f2a842e to bda4330 Compare September 30, 2026 07:07
Base automatically changed from claude/port-ci-plugins to main September 30, 2026 07:16
Integrate the independently authored and reviewed 0aba87964e2f CLI fix
into the custom fork. Preserve the existing eval-argv owner and bare
input-type stdin routing, including explicit-dash argv markers.

Version-query upstream publication is separate; bare and empty-source
followup will credit the existing oven-sh#38566 explicit-dash work.

(cherry picked from commit 2e3ce72)
Integrates oven-sh#43347 while retaining the shared eval dispatcher and existing custom runtime fixes.

(cherry picked from commit 0438136)
@steipete
steipete force-pushed the claude/port-ci-cli-process branch from 70d8fa5 to 1867ab0 Compare September 30, 2026 07:16
@steipete
steipete merged commit 7e4a38e into main Sep 30, 2026
10 of 16 checks passed
@steipete
steipete deleted the claude/port-ci-cli-process branch September 30, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant