Skip to content

fix(runtime): avoid caching runtime plugin resolutions - #25

Closed
steipete wants to merge 3 commits into
mainfrom
claude/runtime-plugin-cache-0929
Closed

steipete wants to merge 3 commits into
mainfrom
claude/runtime-plugin-cache-0929

Conversation

@steipete

@steipete steipete commented Sep 30, 2026 •

Copy link
Copy Markdown

Runtime plugin answers can change between processes, but they are not part of the content-addressed transpiler cache key. Cached rewritten imports can retain a stale absolute path, including a deleted temporary module generation.

This replacement for #14 preserves Vincent Koc’s original commits and composes them with fork main at 3fc6250eff. The only conflict was in CHANGELOG.md; both entries are retained. Accepted runtime onResolve answers suppress the cache write, while declined hooks and ordinary source namespaces retain caching. Cache version 34 rejects old output and is distinct from version 33 on the fork base and inspected upstream sync tip. Thanks @vincentkoc.

Qualified head: e4767999e0a994b4411d637f63994864473ce78f, macOS release build, WebKit f20ce7744553c910bcf16a33faf976af208de091.

Suite Passed Failed
test/cli/run/transpiler-cache.test.ts 27 0
test/cli/test/isolation.test.ts (--max-concurrency 2) 41 0
test/js/bun/plugin/plugins.test.ts 47 0
test/js/bun/plugin/plugin-namespace-drive-letter.test.ts 1 0

Initial local runs encountered three cache-suite timeouts and the existing isolation socket observer’s deadline failure at the default outer concurrency. The cache suite passed unchanged on retry. The socket case passed alone, and all 41 isolation tests passed with outer concurrency capped at two; assertions, timeouts, and nested --parallel coverage were unchanged. All 116 tests passed in the reported runs.

Codex review found no actionable P0–P2 findings. git diff --check and applicable hosted checks passed, apart from the known environment-validation bot failure.

vincentkoc and others added 3 commits September 27, 2026 20:26
Preserve Vincent Koc’s original commits and combine both changelog entries. Cache version 34 remains distinct from main and upstream version 33.

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
@steipete
steipete marked this pull request as ready for review September 30, 2026 02:48
@steipete

Copy link
Copy Markdown
Author

Superseded by #14, squash-merged as 9558178. The exact qualified head from this replacement was fast-forwarded onto the original same-repository branch without rewriting history, preserving Vincent Koc as the squash author. All 116 reported native tests and applicable hosted checks passed; the qualification details remain in #14.

@steipete steipete closed this Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants