Conversation
Preserve Vincent Koc’s original commits and combine both changelog entries. Cache version 34 remains distinct from main and upstream version 33. Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
steipete
marked this pull request as ready for review
September 30, 2026 02:48
Author
|
Superseded by #14, squash-merged as 9558178. The exact qualified head from this replacement was fast-forwarded onto the original same-repository branch without rewriting history, preserving Vincent Koc as the squash author. All 116 reported native tests and applicable hosted checks passed; the qualification details remain in #14. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime plugin answers can change between processes, but they are not part of the content-addressed transpiler cache key. Cached rewritten imports can retain a stale absolute path, including a deleted temporary module generation.
This replacement for #14 preserves Vincent Koc’s original commits and composes them with fork main at
3fc6250eff. The only conflict was inCHANGELOG.md; both entries are retained. Accepted runtimeonResolveanswers suppress the cache write, while declined hooks and ordinary source namespaces retain caching. Cache version 34 rejects old output and is distinct from version 33 on the fork base and inspected upstream sync tip. Thanks @vincentkoc.Qualified head:
e4767999e0a994b4411d637f63994864473ce78f, macOS release build, WebKitf20ce7744553c910bcf16a33faf976af208de091.test/cli/run/transpiler-cache.test.tstest/cli/test/isolation.test.ts(--max-concurrency 2)test/js/bun/plugin/plugins.test.tstest/js/bun/plugin/plugin-namespace-drive-letter.test.tsInitial local runs encountered three cache-suite timeouts and the existing isolation socket observer’s deadline failure at the default outer concurrency. The cache suite passed unchanged on retry. The socket case passed alone, and all 41 isolation tests passed with outer concurrency capped at two; assertions, timeouts, and nested
--parallelcoverage were unchanged. All 116 tests passed in the reported runs.Codex review found no actionable P0–P2 findings.
git diff --checkand applicable hosted checks passed, apart from the known environment-validation bot failure.