Repository navigation
refactor(resolver): name package target resolution options - #149
Merged
Merged
Conversation
Preserve all six call sites and recursive array/map semantics while replacing ambiguous boolean arguments with named options. Resolve inherited Mordant diagnostics without changing the lint baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust Mordant check on main reports
bare_bool_argsfor package-target resolution. Replace the two positional booleans withResolveTargetOptions, preserving all six callers and recursive array/map behavior. The lint baseline is unchanged.This extracts the independent resolver cleanup from #144 so TLS teardown remains a separate review and merge. There is no TLS dependency on this refactor.
Validation: independent Codex review at P1 is scoped-clean. The existing packagejson suite passes with 94 passes and 14 existing TODOs using the previously built binary containing the identical resolver source. Exact-head native CI passes on Darwin and Linux, and Rust CI passes Mordant, Clippy, Miri, and lol-html. An initial local invocation stopped before tests because test dependencies were missing; after frozen-lockfile installation, the complete suite passed.
The advisory duplicate-finder could not run because its provider credentials are not configured. No repository settings or secrets were changed.