add gitleaks secret scanner #20

fishkerez · 2022-12-12T07:45:45Z

No description provided.

.families.yaml

cli/cmd/root.go

shared/pkg/families/sbom/family.go

shared/pkg/families/secrets/family.go

shared/pkg/families/secrets/result.go

shared/pkg/families/secrets/family.go

.families.yaml

shared/pkg/families/sbom/family.go

shared/pkg/families/secrets/config.go

shared/pkg/families/secrets/family.go

shared/pkg/families/secrets/result.go

config.yaml

shared/pkg/families/secrets/family.go

shared/pkg/families/secrets/gitleaks/gitleaks.go

config.yaml

shared/pkg/families/sbom/family.go

shared/pkg/families/secrets/gitleaks/gitleaks.go

ghost

Looks pretty close, a few more comments and then we'll be there

.families.yaml

ghost

Over all its looking good, just needs to get through CI. I have one comment you might want to address to remove your personal info from the .families.yaml, but thats up to you, I think it would be best to solve it

fishkerez changed the title ~~add gitleaks~~ Draft: add gitleaks Dec 12, 2022

fishkerez requested review from a user and FrimIdan and removed request for a user and FrimIdan December 12, 2022 10:28

fishkerez self-assigned this Dec 12, 2022

ghost suggested changes Dec 12, 2022

View reviewed changes

FrimIdan reviewed Dec 12, 2022

View reviewed changes

Erez Fishhimer added 3 commits December 14, 2022 01:23

add gitleaks

add28ff

use manager job factory

da5930c

more

3f40f37

fishkerez force-pushed the add-gitleaks-as-scanner branch from 5a9b8c9 to 3f40f37 Compare December 14, 2022 08:22

FrimIdan reviewed Dec 14, 2022

View reviewed changes

config.yaml Outdated Show resolved Hide resolved

shared/pkg/families/secrets/family.go Outdated Show resolved Hide resolved

shared/pkg/families/secrets/gitleaks/gitleaks.go Outdated Show resolved Hide resolved

review

24fde28

ghost reviewed Dec 14, 2022

View reviewed changes

config.yaml Show resolved Hide resolved

ghost reviewed Dec 14, 2022

View reviewed changes

shared/pkg/families/sbom/family.go Show resolved Hide resolved

ghost reviewed Dec 14, 2022

View reviewed changes

shared/pkg/families/secrets/gitleaks/gitleaks.go Outdated Show resolved Hide resolved

ghost reviewed Dec 14, 2022

View reviewed changes

shared/pkg/families/secrets/gitleaks/gitleaks.go Show resolved Hide resolved

ghost suggested changes Dec 14, 2022

View reviewed changes

Erez Fishhimer added 2 commits December 14, 2022 17:14

wip

c8db8e2

revert config changes

1b1f0c8

ghost reviewed Dec 15, 2022

View reviewed changes

.families.yaml Outdated Show resolved Hide resolved

ghost previously approved these changes Dec 15, 2022

View reviewed changes

change input

2d96b6a

fishkerez dismissed ghost ’s stale review via 2d96b6a December 15, 2022 09:08

ghost previously approved these changes Dec 15, 2022

View reviewed changes

FrimIdan previously approved these changes Dec 15, 2022

View reviewed changes

add licenses

bbd8719

fishkerez dismissed FrimIdan’s stale review via bbd8719 December 15, 2022 09:22

fishkerez dismissed ghost ’s stale review via bbd8719 December 15, 2022 09:22

fishkerez changed the title ~~Draft: add gitleaks~~ add gitleaks secret scanner Dec 15, 2022

fishkerez merged commit 736bd8f into main Dec 15, 2022

fishkerez deleted the add-gitleaks-as-scanner branch December 15, 2022 09:35

Uh oh!

add gitleaks secret scanner #20

add gitleaks secret scanner #20

Uh oh!

Conversation

fishkerez commented Dec 12, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants