Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mississauga scraper since new mayor has been elected #434

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix Mississauga scraper since new mayor has been elected #434

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cd9c90
Fix Mississauga scraper since new mayor has been elected
seamuslee001 Oct 28, 2024
0922876
Modify scraper as per James to be less breaky in future
seamuslee001 Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions ca_on_mississauga/people.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,22 @@ def scrape(self):
if "vacant" not in councillor_url.xpath(".//div//div[1]/text()")[0].lower():
yield self.councillor_data(councillor_url.attrib["href"])

mayor_page = self.lxmlize(MAYOR_PAGE)
mayor_name = mayor_page.xpath('//*[@id="com-main"]/div/div/div/h1/text()')[0]
if "vacant" not in mayor_name.lower():
yield self.mayor_data(MAYOR_PAGE)
mayor_url = page.xpath('//li/a[contains(@href, "mayor")]')[0]
if "vacant" not in mayor_url.xpath(".//div//div[1]/text()")[0].lower():
yield self.mayor_data(mayor_url.attrib["href"])

def councillor_data(self, url):
page = self.lxmlize(url)

name_district = page.xpath('//*[@id="com-main"]/div/div/div/h1/text()')[0]
hyphen = name_district.find("Councillor")
if hyphen == -1:
hyphen = 9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the significance of the magic numbers 9, 27 and 8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmckinney so for 9 it was the length of "Ward 5 –" because unhelpfully the council didn't include the word "Councillor" on Natalie's page title https://www.mississauga.ca/council/city-council-members/ward-5-councillor-natalie-hart/ . For 27 it was the length of "Councillor and Deputy Mayor" in regards to Matt's title as i was hitting errors if the string and Deputy Mayor were not removed https://www.mississauga.ca/council/city-council-members/ward-8-councillor-matt-mahoney/ . For 8 it is the length of "Mayor - " to remove it from Carolyn's page title https://www.mississauga.ca/council/city-council-members/mayor-carolyn-parrish/

I wasn't sure if there were better ways to resolve these random matters

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest doing things like variable.replace("Councillor and Deputy Mayor", "").strip(), that way if there is no match, nothing special happens. Right now, if there's no match, the string will be cut at a strange index.

district = name_district[: hyphen - 3]
name = name_district[hyphen:]
mayor = name.find("Deputy")
if mayor != -1:
name = name[27:]
bracket = name.find("(")
if bracket != -1:
name = name[:bracket]
Expand All @@ -47,9 +51,9 @@ def councillor_data(self, url):
def mayor_data(self, url):
page = self.lxmlize(url)

name_text = page.xpath('//*[@id="com-main"]/div/div/div/h1/text()')[0]
name = name_text.split(",")[0]
photo = page.xpath('//img[contains(@src, "mayor")]/@src')[0]
name = page.xpath('//*[@id="com-main"]/div/div/div/h1/text()')[0]
name = name[8:]
photo = page.xpath('//*[@id="65a01af8598b7"]/p[1]/img/@src')[0]

p = Person(primary_org="legislature", name=name, district="Mississauga", role="Mayor")
p.add_source(url)
Expand Down