-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update DE constituencies for 2025 snap election #394
Conversation
Dear @jloutsenhizer @jpmckinney , can you please have a quick look, maybe we can figure out a solution for germany. |
RE So in the example you shared, it looks like we should update |
Thank you for the reply, When we update the sameAs entry for we would lose the Will that be a problem? If not, I am happy to adjust all those chain entries in the aliases file. |
That should be fine, aliases are meant to be transitive, so the check that's failing is making sure that there isn't unnecessary chaining to get to the canonical OCD ID |
Okay, I cleaned up the aliases file and compiled the Please have a look at the results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't thoroughly looked through the changes but left some comments on initial issues I saw.
Overall, I wanted to confirm that it is the name that carries the identity of the district, and not the number. So even though the number of many districts changed, since the name remains the same it'd be accurate to say people running for re-election are running in the same district and, if they win, have a continuous tenure?
@jpmckinney can you take a look for approval? |
@HKSenior I have the same comments as @jloutsenhizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates from last comments LGTM.
I spotchecked a few existing, added, and removed constituencies and didn't notice anything wrong.
Adding README
Why we propose to change the ocd_paths back using names instead of numbers
aliases.csv
fileWe can not build the new country CSV file because the alias file has chains
Example:
ocd-division/country:de/ed:60
using the name instead of the numberHow can we proceed from here, since the election is near and we need those OCDs to official.
Best,