-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OCDs for Italy #389
Add OCDs for Italy #389
Conversation
identifiers/country-it/README.md
Outdated
- [senato (senate / upper house)](https://dait.interno.gov.it/territorio-e-autonomie-locali/sut/elenco_collegi_senato.php) | ||
- Collegio plurinominale as **cp** | ||
- Collegio uninominale as **cu** | ||
* Collegio plurinominale and Collegio uninominale of the Camera of Italy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be helpful to add the english translation in parenthesis. For example, "Collegio plurinominale (Multi-member college) and Collegio uninominale (Single-member constituency)". Same for Camera. Please update here and above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, added english translation to readme.
identifiers/country-it.csv
Outdated
ocd-division/country:it/senato:campania/cu:5,Collegio uninominale Campania - 05 | ||
ocd-division/country:it/senato:campania/cu:6,Collegio uninominale Campania - 06 | ||
ocd-division/country:it/senato:campania/cu:7,Collegio uninominale Campania - 07 | ||
ocd-division/country:it/senato:diaspora-_africa_asia_oceania_e_antartide,Abroad - Africa Asia Oceania and Antarctica |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dash can be removed here and below.
ocd-division/country:it/senato:diaspora-_africa_asia_oceania_e_antartide,Abroad - Africa Asia Oceania and Antarctica | |
ocd-division/country:it/senato:diaspora_africa_asia_oceania_e_antartide,Abroad - Africa Asia Oceania and Antarctica |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjusted
identifiers/country-it/senato.csv
Outdated
ocd-division/country:it/senato:veneto,Circoscrizione Veneto | ||
ocd-division/country:it/senato:diaspora-_europa,Abroad - Europe | ||
ocd-division/country:it/senato:diaspora-_america_settentrionale_e_centrale,Abroad - North and Central America | ||
ocd-division/country:it/senato:diaspora-_america_meridionale,Abroad - South America |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dash can be removed here and below.
ocd-division/country:it/senato:diaspora-_america_meridionale,Abroad - South America | |
ocd-division/country:it/senato:diaspora_america_meridionale,Abroad - South America |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjusted
@HKSenior thanks a lot for the review. The requested changes have been implemented. |
Instead of The readme links to regions, but regions are not the same as Circoscrizione. There can be multiple Circoscrizione per region, for the lower house: https://it.wikipedia.org/wiki/Collegi_elettorali_della_Camera_dei_deputati_del_2020 It also looks like the single-member constituencies should be children of the multi-member constituencies. Overall, I think the hierarchy would be:
Edit: By splitting the region from the lower circoscrizione, we also get rid of the |
Yes, we can replace
There are no multi-member constituencies for the Circoscrizione
That is a good idea, the ocd-paths can the look like something like the following:
what do you think? |
Alright, I updated the files, adde Regions and adjusted the OCDs for upper and lower house. I also enhanced the name of the single-member constituencies. Please have another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This touches country-lt.csv (Lithuania) as well?
- Although I had suggested it, now that I see it, I think the
region:
level is repetitive, and also might imply that the mmc and ed are with respect to the regional government, whereas these are about representation at the federal level. Therefore, it might be better to remove the region level. Curious to hear from other maintainers.
307f026
to
33c125c
Compare
Good catch! That was mistakenly pushed -> fixed. |
Hi, I would also suggest leaving out the region. They can be problematic for several reasons:
|
@jpmckinney should I remove the And should I also remove the |
Yes please! |
Alright. Regions removed from country IT OCDs. Please have a look again. |
Adding OCDs for Italy's senate and camera.
100 for Senate
196 for Camera