Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCDs for Italy #389

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

zikowang
Copy link
Contributor

Adding OCDs for Italy's senate and camera.

100 for Senate

  • 26 Collegio plurinominale
  • 74 Collegio uninominale

196 for Camera

  • 49 Collegio plurinominale
  • 147 Collegio uninominale

- [senato (senate / upper house)](https://dait.interno.gov.it/territorio-e-autonomie-locali/sut/elenco_collegi_senato.php)
- Collegio plurinominale as **cp**
- Collegio uninominale as **cu**
* Collegio plurinominale and Collegio uninominale of the Camera of Italy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to add the english translation in parenthesis. For example, "Collegio plurinominale (Multi-member college) and Collegio uninominale (Single-member constituency)". Same for Camera. Please update here and above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, added english translation to readme.

ocd-division/country:it/senato:campania/cu:5,Collegio uninominale Campania - 05
ocd-division/country:it/senato:campania/cu:6,Collegio uninominale Campania - 06
ocd-division/country:it/senato:campania/cu:7,Collegio uninominale Campania - 07
ocd-division/country:it/senato:diaspora-_africa_asia_oceania_e_antartide,Abroad - Africa Asia Oceania and Antarctica
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dash can be removed here and below.

Suggested change
ocd-division/country:it/senato:diaspora-_africa_asia_oceania_e_antartide,Abroad - Africa Asia Oceania and Antarctica
ocd-division/country:it/senato:diaspora_africa_asia_oceania_e_antartide,Abroad - Africa Asia Oceania and Antarctica

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted

ocd-division/country:it/senato:veneto,Circoscrizione Veneto
ocd-division/country:it/senato:diaspora-_europa,Abroad - Europe
ocd-division/country:it/senato:diaspora-_america_settentrionale_e_centrale,Abroad - North and Central America
ocd-division/country:it/senato:diaspora-_america_meridionale,Abroad - South America
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dash can be removed here and below.

Suggested change
ocd-division/country:it/senato:diaspora-_america_meridionale,Abroad - South America
ocd-division/country:it/senato:diaspora_america_meridionale,Abroad - South America

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted

@zikowang
Copy link
Contributor Author

zikowang commented Aug 30, 2024

@HKSenior thanks a lot for the review.

The requested changes have been implemented.

@zikowang zikowang requested a review from HKSenior August 30, 2024 05:51
@jpmckinney
Copy link
Member

jpmckinney commented Sep 6, 2024

Instead of cameri and senato, how about lower and upper? That way jurisdictions can be comparable, instead of having local type IDs for lower and upper chambers of parliament.

The readme links to regions, but regions are not the same as Circoscrizione. There can be multiple Circoscrizione per region, for the lower house: https://it.wikipedia.org/wiki/Collegi_elettorali_della_Camera_dei_deputati_del_2020

It also looks like the single-member constituencies should be children of the multi-member constituencies.

Overall, I think the hierarchy would be:

  • region
    • upper (circoscrizione) – can maybe skip this level if we assume that the relationship will remain 1-to-1 in future
      • mmc (multi-member constituency)
        • smc or ed (single-member constituency or electoral district)
    • lower (circoscrizione)
      • mmc (multi-member constituency)
        • smc or ed (single-member constituency or electoral district)

Edit: By splitting the region from the lower circoscrizione, we also get rid of the cp:1-1 style IDs, as the first 1 belongs to the circoscrizione, not the mmc.

@zikowang
Copy link
Contributor Author

zikowang commented Sep 10, 2024

Instead of cameri and senato, how about lower and upper? That way jurisdictions can be comparable, instead of having local type IDs for lower and upper chambers of parliament.

Yes, we can replace senato and cameri with lower and upper.

The readme links to regions, but regions are not the same as Circoscrizione. There can be multiple Circoscrizione per region, for the lower house: https://it.wikipedia.org/wiki/Collegi_elettorali_della_Camera_dei_deputati_del_2020
It also looks like the single-member constituencies should be children of the multi-member constituencies.

There are no multi-member constituencies for the Circoscrizione Valle D'Aosta and Trentino-Alto Adige in senate.
And there are no multi-member constituencies for the Circoscrizione Valle D'Aosta in camrea.

Edit: By splitting the region from the lower circoscrizione, we also get rid of the cp:1-1 style IDs, as the first 1 belongs to the circoscrizione, not the mmc.

That is a good idea, the ocd-paths can the look like something like the following:
For example for "Campania" in camera:

id, name
ocd-division/country:it,Italy

ocd-division/country:it/region:campania,Region Campania

ocd-division/country:it/region:campania/lower:campania-1,Circoscrizione Campania 1
ocd-division/country:it/region:campania/lower:campania-2,Circoscrizione Campania 2

ocd-division/country:it/region:campania/lower:campania-1/mmc:1,Collegio plurinominale Campania 1

ocd-division/country:it/region:campania/lower:campania-1/mmc:1/ed:1,Collegio uninominale Campania 1 - 01
...
ocd-division/country:it/region:campania/lower:campania-2/mmc:1/ed:1,Collegio uninominale Campania 2 - 01
...

what do you think?

@jpmckinney
Copy link
Member

Looks good!

There are no multi-member constituencies for the Circoscrizione Valle D'Aosta and Trentino-Alto Adige in senate.
And there are no multi-member constituencies for the Circoscrizione Valle D'Aosta in camrea.

Aha, for those, I guess ed will be a child of upper/lower.

@zikowang
Copy link
Contributor Author

Alright, I updated the files, adde Regions and adjusted the OCDs for upper and lower house.

I also enhanced the name of the single-member constituencies.

Please have another look.

Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This touches country-lt.csv (Lithuania) as well?
  • Although I had suggested it, now that I see it, I think the region: level is repetitive, and also might imply that the mmc and ed are with respect to the regional government, whereas these are about representation at the federal level. Therefore, it might be better to remove the region level. Curious to hear from other maintainers.

@zikowang
Copy link
Contributor Author

This touches country-lt.csv (Lithuania) as well?

Good catch! That was mistakenly pushed -> fixed.

@sguenther85
Copy link
Contributor

  • This touches country-lt.csv (Lithuania) as well?
  • Although I had suggested it, now that I see it, I think the region: level is repetitive, and also might imply that the mmc and ed are with respect to the regional government, whereas these are about representation at the federal level. Therefore, it might be better to remove the region level. Curious to hear from other maintainers.

Hi, I would also suggest leaving out the region. They can be problematic for several reasons:

  • the same thing you said @jpmckinney : might imply that the mmc and ed are with respect to the regional government. That's why the ed in germany are directly under country for the “federal election”
  • if constituencies with numbers/names could span or switch regions
  • generally no added value, except more work

@zikowang
Copy link
Contributor Author

zikowang commented Sep 17, 2024

@jpmckinney should I remove the region: level before lower: and upper: so we can move on?

And should I also remove the regions file and the regions-part of the readme because it is not in use anymore?

@jpmckinney
Copy link
Member

Yes please!

@zikowang
Copy link
Contributor Author

Alright. Regions removed from country IT OCDs.

Please have a look again.

@HKSenior HKSenior merged commit db27af6 into opencivicdata:master Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants