-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update constituencies for the 2021 Bundestag Election #252
Conversation
@jloutsenhizer @sguenther85 can you please have a look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why github is showing the wahlkreise.csv file as being completely changed, the two lines changed lgtm. One comment around the aliases and then I think this change will be good
hi, was the complete last week on "vacation" (or how you call it in the current time). ;) i'll look over it again and get back to you. i also have another question according to ocds and the Bundestagswahl. |
Hi, both changes looking good for me. So for the "german feder election" itself it must be onyl the ed's. It is possible to list for several different level elections the ocd-paths in one file? Its a little bit the same problem we have for UK (GB) where we tried to list constituencies for UK Election and Scotland Election. In this case we have here also the same problem that we have two times the same constituency "name" for two election, but with an different cut on the map. |
As explained in the wikipedia page, If a party wins fewer constituency seats in a state than its second votes would entitle it to, it receives additional seats from the relevant state list. So, I guess, the states level is important to represent the electoral system in that case.
|
@azuser In previous threads the discussion has focused on not how seats are allocated within the electoral system, but which governmental body has authority over creating the geographic entities [1, 2, 3] So the principle here is not how any particular electoral system uses the boundaries or geographic entities, but at which level of government they are created and updated. @jpmckinney for another opinion, though. |
In Canada, the constitution allocates seats in the federal legislature (each of which has a corresponding division) to each province (single-seat ridings). A boundary commission then sets the boundaries of the divisions. Canada has provincial legislatures, which are not required to use the same number of seats or shape of divisions as the federal level, though some do. The provincial electoral divisions are set by different legislation and boundary commissions. As such, in Canada, federal divisions are at ocd-division/country:ca/ed: whereas provincial divisions are at ocd-division/country:ca/province:on/ed:, etc. It seems like the situation is similar in Germany, so a similar model should be used. Regarding the use of party lists, you can just use the state divisions ocd-division/country:de/land:xx, etc. if needed. There is no need to nest federal divisions under |
thanks for the information. i will have a look at the comparison between canada and germany. |
I think
For local-level divisions, there is less standardization, e.g. ward, district, borough, division. I notice that Canada uses |
Thanks all for providing context! The delimitation of constituencies is proposed by an independent Electoral Districts Commission and validated then by the German Bundestag (ref). So, in that case, if I rely on previous UK discussions, it makes sense to update the existing hierarchies as proposed previously . Example:
However, as we decide to update the existing OCD ids, I am wondering if that correction could affect other users. WDYT ? |
@azuser Your comment last time about the seats which you can get over the state-list was correct. So we still need the state level for the candidates who run on these lists or both (state-list and const. list) |
Yeah, I was thinking to keep the states and update the constituencies. So, we will have both states and constituencies attached to WDYT ? |
I updated the wahlkreise file, please have a look. I also updated the aliases file with the new ocd-ids, however, I am not sure if I should do the same for aliases ids (example |
I think the alias IDs shouldn't be changed, clients of the data should use the canonical forms of the OCD IDs. Only request I'd have for the current state is for aliases to be added for all of the old OCD IDs to the new ones that hang directly off of |
Done. However, I am wondering if at some point we decide to add states constituencies. It can be confusing if we use the same identifiers. |
When state constituencies are added, they should use distinct OCD IDs from these previous ones regardless of whether or not these aliases existed. Otherwise there could be data laying around using these ones for the Bundestag constituencies which would then be confused for the state constituencies. With the additional aliases added, these changes LGTM |
LGTM. Thanks @jloutsenhizer. @jdmgoogle @sguenther85 @jpmckinney other thoughts ? |
No. Looks goot to me. |
Thanks all, @jpmckinney can you please approve my CL and submit it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we using cd
(congressional district) instead of ed
(electoral district)? Since we're creating new IDs, we might as well use the more sensical type.
Thanks for checking! I thought it is better to keep the already used type! Happy to change it ! |
I would also prefer ed: instead of cd: |
Sorry for the delay ! @jpmckinney if the change looks good to you, can you please merge it ? |
Reference: https://www.bundeswahlleiter.de/en/bundestagswahlen/2021/wahlkreiseinteilung.html#main