Add ocd-id for all states in Vidhan Sabha.

[novitam]

Adding all Vidhan Sabha constituencies.

[novitam]

@jloutsenhizer PTAL. Thanks.

[jloutsenhizer]

I noticed just a couple more potential issues. I think in general this is looking good.

[jloutsenhizer]

Looks good to me.

@jpmckinney for second review.

[jpmckinney]

The name column is very repetitive, e.g. " district; "

1. Omit the state name. The state has its own ID, where its name is given.
2. Omit the type name (district, constituency, etc.). This is implied by the district:, cd:, etc. type.
3. Omit double spaces. Single spaces only.

[novitam]

Made the corrections to the name column as requested.

[jpmckinney]

If I add up all the districts on this page, I get 728 districts: http://www.goidirectory.gov.in/district.php districts.csv has 666. Can you add a readme to explain the difference?

In vidhan_sabha.csv, please omit the district name, as was done earlier to omit the state name.

I believe https://en.wikipedia.org/wiki/State_legislative_assemblies_of_India is out of date, which has 4,121 constituencies. The Hindi page https://hi.wikipedia.org/wiki/विधान_सभा has 4,126 constituencies. (The Urdu page https://ur.wikipedia.org/wiki/ودھان_سبھا has 4,120) However, the file has only 4,031 constituencies. Can you add a readme to explain the difference?

[novitam]

@jpmckinney I have vetted through the list again, and made some updates.

There were some states in which the ECI (Election Commission of India) have redrawn the boundaries, and hence some updates to the constituencies were required.

This pull request contains less constituencies because we are currently excluding the constituencies for Jammu & Kashmir. The State Legislative Assembly was dissolved, and the state is currently undergoing a delimitation exercise. I will create a separate pull request for Jammu & Kashmir when the delimitation exercise has been concluded.

As for the list in http://www.goidirectory.gov.in/district.php, the website is actually showing the administrational boundaries, which is different than the electoral boundaries decided by the ECI. Hence, this pull request doesn't match the list in the website as we are only following and considering the electoral boundaries. For example: Kalimpong in West Bengal is a district that is listed in http://www.goidirectory.gov.in/district.php, because Kalimpong is a district and is an administration boundary. However, there are no Assembly Constituencies (AC) in Kalimpong district (i.e. the ECI allocates the ACs under Kalimpong administration boundary to another electoral district)- hence the absence of Kalimpong district under the state of Karnataka in the this pull request.

[jpmckinney]

Thanks for the clarifications! Just two more comments.

[jpmckinney]

@jloutsenhizer There have been some changes based on my comments. Feel free to merge if all looks good.

[jloutsenhizer]

The changes all look good to me, thanks!