Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top level, state level, and district level OCD-IDs for the Czech Republic #216

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ckaminer
Copy link
Contributor

No description provided.

@azuser
Copy link
Contributor

azuser commented Nov 25, 2020

Could you add a README that defines the types and the standards you used when creating the identifiers ?

@ckaminer
Copy link
Contributor Author

ckaminer commented Dec 9, 2020

Could you add a README that defines the types and the standards you used when creating the identifiers ?

All set 👍

Copy link
Contributor

@azuser azuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you precise the reference you used to generate the ids. When I check Wikipedia https://en.wikipedia.org/wiki/ISO_3166-2:CZ, the ISO ids are numbers.

@jloutsenhizer WDYT ?

@@ -0,0 +1,15 @@
id,name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please order this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by order?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant alphabetical order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants