Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top level OCDID for Netherlands / existing Parliament (Tweede Kamer) #172

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Add top level OCDID for Netherlands / existing Parliament (Tweede Kamer) #172

merged 1 commit into from
Oct 1, 2019

Conversation

sguenther85
Copy link
Contributor

No description provided.

@jdmgoogle
Copy link
Contributor

LGTM

@jdmgoogle
Copy link
Contributor

Although please update the PR description since this only includes the top-level OCD-ID, and not the parliamentary districts (which are blocked on the resolution of #170).

@jpmckinney
Copy link
Member

jpmckinney commented Sep 9, 2019

In some cases we use the English name (Taiwan, etc.), in others we use a local name (Polska, Nederland). Do we have a preference, or is it whatever the contributor proposes?

@sguenther85
Copy link
Contributor Author

I would prefer the local names.
But in cases of Chinese, Korean or Japanese I would suggest the alphabetical variant of the language.
For Example:

Englisch: Japan
Japanese: 日本
Japanese: Nippon

Much better would be a second columnin the .csv File to set the local name and a possible english translation for everybody.

@sguenther85
Copy link
Contributor Author

@jdmgoogle but there are no political districts/region or what else for last netherlands election.
And i can't just add the first level districts without knowing if the geographical districts are also the political districts for elections in the netherlands?

https://en.wikipedia.org/wiki/2017_Dutch_general_election
The House of Representatives (Dutch: Tweede Kamer) is composed of 150 seats elected by proportional representation in a single nationwide constituency, with a legal threshold of 1 full seat (0.67%), and residuals assigned by the D'Hondt method.[6][7] The Senate is indirectly elected by the States-Provincial.

@sguenther85
Copy link
Contributor Author

@jdmgoogle can we approve and merge this PR or is there anything todo? Like i wrote last time: They have only on single nationwide constituency!

@jpmckinney jpmckinney merged commit 423d599 into opencivicdata:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants