Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-7463 Modify CellBase clinical variant builders #721

Merged
merged 6 commits into from
Mar 27, 2025

Conversation

jtarraga
Copy link
Member

Clinical variant builders currently have source versions, such as the ClinVar version, hardcoded in the code. Instead, these builders should retrieve versions from JSON version files created from the configuration.yml file. For example, for the ClinVar data source, the ClinVar builder should use the JSON file clinvarVersion.json.

TASK-7463

… is taken from the xxxVersion.json file, #TASK-7463
@jtarraga jtarraga requested a review from pfurio March 24, 2025 08:27
@imedina
Copy link
Member

imedina commented Mar 24, 2025

@jtarraga jtarraga merged commit 89ce6c2 into release-5.8.x Mar 27, 2025
5 of 6 checks passed
@jtarraga jtarraga deleted the TASK-7463 branch March 27, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants