Update upload/catalog/view/theme/default/template/common/header.tpl #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now when the doctype is HTML5, better if we use the placeholder attribute instead on inline javascipt for the "Search"text in search field. Does not work in IE yet, but it's not a must have feature anyway. This allows for cleaner HTML-code with no JavaScript, it also solves another problem, when you accidently search on the phrase "Search" itself, that can happen sometimes.
opencart
pushed a commit
that referenced
this pull request
Dec 23, 2012
Update upload/catalog/view/theme/default/template/common/header.tpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when the DOCTYPE is HTML5, better if we use the placeholder attribute
instead on inline javascipt for the "Search" text in search field.
Does not work in IE yet, but it's not a must have feature anyway.
This allows for cleaner HTML-code with no JavaScript.
It also solves another problem, when you accidently search on the
phrase "Search" itself, that can happen sometimes.
EDIT: If IE-support is a must, there is always possible to check for
placeholder support with JavaScript, preferebly a function in the common.js
More info: http://davidwalsh.name/html5-placeholder