Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Parquet as Response format. #106

Merged
merged 13 commits into from
Feb 6, 2025
Merged

Support Parquet as Response format. #106

merged 13 commits into from
Feb 6, 2025

Conversation

aratikakadiya
Copy link
Contributor

No description provided.

@aratikakadiya aratikakadiya changed the title Draft: Support Parquet as Response format. Support Parquet as Response format. Dec 3, 2024
pdowler
pdowler requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@pdowler pdowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing checkstyle; you vcan run it locally with

gradle checkstyleMain

Some general comments on the code below...

@aratikakadiya
Changes in code according to changes requested in PR review.
f5bbd75 
Added logic to Read from inputStream.
Added logic to read Schema from footer.
Added basic logic to read actual data in key value pair.
@aratikakadiya
Refactored code(Rename variable names and update log messages)
a9d5dc2
@aratikakadiya
Added VOTable to parquet.
febce06
@aratikakadiya
Handled Non-Primitive data including Primitive Arrays, Timestamp and …
a9c3bf4 
…xtype arrays.

Code Restructuring and Refactoring.
@pdowler pdowler merged commit 518d9a4 into opencadc:main Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdowler pdowler pdowler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aratikakadiya @pdowler